Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Decodeable to j.u.ArrayList #118

Merged
merged 2 commits into from
Jul 9, 2014

Conversation

johnchapin
Copy link
Contributor

NOTE: I have submitted the Eclipse CLA

I've been bitten by this discrepancy a few times recently, especially when passing data between clojure verticles. I think there's precedent - clojure.data.json preserves ILookup semantics in round-tripped data.

Thoughts?

@tobias
Copy link
Contributor

tobias commented Jul 7, 2014

@johnchapin - thanks for the fix! Is there a reason we have to use ArrayList here? Would extending Decodeable to the more general List also work?

@johnchapin
Copy link
Contributor Author

Good call - List would be better and lines up with the list of extended classes for Encodeable. I've updated the PR.

tobias added a commit that referenced this pull request Jul 9, 2014
Extend Decodeable to j.u.ArrayList
@tobias tobias merged commit 892350d into vert-x:master Jul 9, 2014
@tobias
Copy link
Contributor

tobias commented Jul 9, 2014

Looks good, thanks @johnchapin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants