Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential XXE vulnerability in vertx-web #406

Closed
brianwrf opened this issue Sep 27, 2018 · 1 comment
Closed

Potential XXE vulnerability in vertx-web #406

brianwrf opened this issue Sep 27, 2018 · 1 comment

Comments

@brianwrf
Copy link

Howdy,

Just found a potential XXE vulnerability in vertx-web as show below, it seems function isValid didn't add any protection from XXE vulnerability when parsing XML document.

https://github.com/vert-x3/vertx-web/blob/2ce5bd4f3ca5a8f81d952d5c7b3d555dea5c41e6/vertx-web-api-contract/src/main/java/io/vertx/ext/web/api/validation/impl/XMLTypeValidator.java#L34

Follow the OWASP guide below which provides concise information to prevent this vulnerability. https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat_Sheet#Java

Thanks,
Brian
@brianwrf
Copy link
Author

Created a new issue for vertx-web instead.
vert-x3/vertx-web#1021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brianwrf