add receiver options to set selector and nolocal filters #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds on vert-x3#67, with tweaks and addition of tests to verify the behaviour. This closes vert-x3#66
sebthom
reviewed
Dec 3, 2021
| public static final UnsignedLong SELECTOR_CODE = UnsignedLong.valueOf(0x0000_468C_0000_0004L); | ||
| public static final Symbol SELECTOR_NAME = Symbol.valueOf("apache.org:selector-filter:string"); | ||
| // For the "apache.org:selector-filter:string" filter | ||
| private static final Symbol SELECTOR_KEY = Symbol.valueOf("selector"); |
There was a problem hiding this comment.
@gemmellr Out of curiosity, why are you using "selector" instead of "apache.org:selector-filter:string" as mentioned on https://www.amqp.org/specification/1.0/filters here?
There was a problem hiding this comment.
Because that is the filters symbolic descriptor, not the value that has to be used as the filter map key (which is actually undefined and not meant to influence behaviour).
There was a problem hiding this comment.
i.e you can send symbol "apache.org:selector-filter:string" as the described type descriptor rather than the ulong numeric descriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add receiver options to set selector and nolocal filters
Builds on #67, with tweaks and addition of tests to verify the behaviour.