Initial Work #1
Merged
Initial Work #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom a spring config server
Add support for Raw type (requried for Kubernetes ConfigMap and Secrets)
…ude" (fileset) pattern.
…tore implementation
fixes for DirectoryConfigurationStore and GitConfigurationStore
Extract the JsonObjectHelper as it can be useful to other store implementations.
…ation-service into cmoulliard-master Slightly change how the namespace is configured, also add a test. # Conflicts: # vertx-configuration-kubernetes-configmap/src/main/java/io/vertx/ext/configuration/kubernetes/ConfigMapStore.java
add a polyglot version of the getConfiguraiton method returning a future.
vietj
reviewed
Jan 19, 2017
| json.completer() | ||
| ); | ||
| return json; | ||
| }).setHandler(ar -> { |
There was a problem hiding this comment.
why not set completionHandler directly ?
vietj
reviewed
Jan 19, 2017
| try { | ||
| completionHandler.handle(Future.succeededFuture(ar.result())); | ||
| } catch (Exception e) { | ||
| completionHandler.handle(Future.failedFuture(e)); |
…ReadStream<JsonObject>
Fix identation #1 (review)
Avoid resuming a multiple times a stream #1 (review) #1 (review)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the work made in my repository. Ready for review.