Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-102] Added support of HTTP headers, timeout, followRedirects to Http Configuration store #103

Merged
merged 1 commit into from
Jan 23, 2020
Merged

[Issue-102] Added support of HTTP headers, timeout, followRedirects to Http Configuration store #103

merged 1 commit into from
Jan 23, 2020

Conversation

gaol
Copy link
Member

@gaol gaol commented Nov 12, 2019 •
edited
Loading

Fixes: #102

  • Using RequestOptions in HttpConfigStore so that it is possible to specify HTTP headers from the configuration.

  • Introduce headers in the configuration

  • Introduce timeout in the configuration

  • Introduce followRedirects in the configuration

  • Do not require the host in configuration, the defaultHost in the HttpClientOptions will take effect if no host specified in the configuration.

@gaol
Copy link
Member Author

gaol commented Nov 12, 2019

@cescoffier @vietj Would you please review? Thanks !

@vietj
Copy link
Contributor

vietj commented Nov 16, 2019

minor comment

@gaol gaol force-pushed the Issue-102 branch 2 times, most recently from 8efabd4 to b9bb43f Compare November 18, 2019 02:15
@gaol
Copy link
Member Author

gaol commented Nov 18, 2019

@vietj Updated to filter out null values from headers.

@gaol gaol mentioned this pull request Nov 20, 2019
Open
@gaol
Copy link
Member Author

gaol commented Jan 20, 2020

I think it goes well, I will merge the PR if no other comments :)

@gaol
Copy link
Member Author

gaol commented Jan 22, 2020

OK, with the updated HttpClient API, I updated this as well to include timeout, followRedirects as well as the headers.

@gaol gaol changed the title [Issue-102] Add HTTP Header to Http Configuration retriever [Issue-102] Added support of HTTP headers, timeout, followRedirects to Http Configuration store Jan 22, 2020
@vietj
Copy link
Contributor

vietj commented Jan 22, 2020

beside the lambda, it's good to merge

@gaol gaol merged commit ef08647 into vert-x3:master Jan 23, 2020
@vietj vietj added this to the 4.0.0 milestone Jan 23, 2020
@vietj
Copy link
Contributor

vietj commented Jan 23, 2020

@gaol any issue you merge or fix needs a version to be set so it can be in the release notes

@gaol
Copy link
Member Author

gaol commented Jan 28, 2020

@vietj Got it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj vietj left review comments

Assignees
No one assigned
Labels
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Add HTTP Header to Http Configuration retriever
2 participants
@gaol @vietj