Fix ByteBuf Leak! #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix LEAK: ByteBuf.release() was not called before it's garbage-collected.
gaol
reviewed
Feb 17, 2023
| @@ -76,8 +76,12 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception | |||
| reading = true; | |||
| if (msg instanceof BinaryWebSocketFrame) { | |||
| BinaryWebSocketFrame frame = (BinaryWebSocketFrame) msg; | |||
| String json = frame.content().toString(StandardCharsets.UTF_8); | |||
| messageHandler.handle(json); | |||
| try { //TODO: @wjw_note: release BinaryWebSocketFrame Prevent resource leakage! | |||
There was a problem hiding this comment.
What is the purpose of this line ? can we remove it ? others LGTM
There was a problem hiding this comment.
use try finally promise release BinaryWebSocketFrame Prevent resource leakage!
There was a problem hiding this comment.
sorry, I meant the comment: //TODO: @wjw_note: release BinaryWebSocketFrame Prevent resource leakage!
There was a problem hiding this comment.
Sorry again that I did not make myself clear, and to be precise, it is TODO: @wjw_note:, I don't want to be captious, but TODO means something not ready, and the @wjw_note looks like not this component related.
There was a problem hiding this comment.
Sorry, the TODO & wjw__note in this comment is misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix LEAK: ByteBuf.release() was not called before it's garbage-collected.