Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IP address parsing regression introduced in 4.4.3 #306

Merged
merged 1 commit into from Jun 8, 2023
Merged

Fix IP address parsing regression introduced in 4.4.3 #306

merged 1 commit into from Jun 8, 2023

Conversation

vietj
Copy link
Contributor

@vietj vietj commented Jun 8, 2023

No description provided.

@vietj vietj force-pushed the fix-server-address-regression branch 3 times, most recently from b0c9df1 to 3dce4cd Compare June 8, 2023 09:55
@vietj vietj changed the title Fix IP address parsing regression introduced in last release Fix IP address parsing regression introduced in 4.4.3 Jun 8, 2023
tsegismont
tsegismont reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vietj

src/main/java/io/vertx/ext/jdbc/impl/JDBCClientImpl.java Outdated Show resolved Hide resolved
src/test/java/io/vertx/jdbcclient/JDBCTracingTest.java Show resolved Hide resolved
@vietj vietj force-pushed the fix-server-address-regression branch from 3dce4cd to 19b978c Compare June 8, 2023 14:11
tsegismont
tsegismont approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @vietj

Ideally we'd have test params for IPv6 case

@vietj vietj added this to the 4.4.3.1 milestone Jun 8, 2023
@vietj vietj added the bug label Jun 8, 2023
@vietj vietj self-assigned this Jun 8, 2023
@vietj vietj merged commit 1d5fe86 into 4.x Jun 8, 2023
4 checks passed
@vietj vietj deleted the fix-server-address-regression branch June 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsegismont tsegismont tsegismont approved these changes

Assignees

@vietj vietj

Labels
bug
Milestone
4.4.3.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vietj @tsegismont