Upgrade to Kotlin 1.3.60

[jponge]

Also upgraded the Kotlin coroutines library.

ReceiveChannelHandler had to be added a field and a method due to additions in ReceiveChannel.
These are internal APIs so I made them throw NotImplementedError (through TODO("...")) and all tests still pass so it doesn't seem to be on a typical call path.

[jponge]

I've had to implement this in ReceiveChannelHandler due to new internal APIs:

  @InternalCoroutinesApi
  override val onReceiveOrClosed: SelectClause1<ValueOrClosed<T>>
    get() = TODO("not implemented")

  @InternalCoroutinesApi
  override suspend fun receiveOrClosed(): ValueOrClosed<T> {
    TODO("not implemented")
  }
}

This makes the code compile, and the tests suite do not seem to exerce that call path.

[slinkydeveloper]

Can you check why it fails?

[jponge]

It worked on my machine so...

…

On 26 Nov 2019, at 09:32, Francesco Guardiani ***@***.***> wrote: Can you check why it fails? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[vincentfree]

Kotlin updated to 1.3.61 containing fixes, the pull request hasn't been merged yet so maybe it's a good idea to update it to 1.3.61 before it does.

[vincentfree]

I've had to implement this in ReceiveChannelHandler due to new internal APIs:

  @InternalCoroutinesApi
  override val onReceiveOrClosed: SelectClause1<ValueOrClosed<T>>
    get() = TODO("not implemented")

  @InternalCoroutinesApi
  override suspend fun receiveOrClosed(): ValueOrClosed<T> {
    TODO("not implemented")
  }
}

This makes the code compile, and the tests suite do not seem to exerce that call path.

I had to overcome this problem because I have the new 1.3.2 coroutines dependency in one of my applications.

I've added it like this:

override suspend fun receiveOrClosed(): ValueOrClosed<T> {
        return channel.receiveOrClosed()
    }
}

This way I was able to use Flow and create one form a Channel.

[jponge]

Thanks @vincentfree

I've added delegation to both methods.

[AlexeySoshin]

I've attempted to merge with master:
#164

[AlexeySoshin]

@vietj Did it go out of sync again? :(

[vietj]

I will have a look rebasing this PR tomorrow

[AlexeySoshin]

Any update on that? :)

[vietj]

on it :-)

[vietj]

Cherry-picked in master, can you have a check @jponge @AlexeySoshin ?

[jponge]

LGTM

[AlexeySoshin]

Amazing!
Now I can start looking at Kotlin 1.3.70 :)