Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Even after the recent change (#207) to offer a future-based API, the mail client internals remained heavily callback-oriented, with some idiosyncratic quirks.
This PR changes most of the implementation to be future-based, which allows a lot of code cleanup. I wasn't aware of #194, so there's a lot of overlap. The
SMTPConnection
class still holds the 2 handlers and further refactoring would be great, I just couldn't figure it out myself. I'll see if I can find some inspiration in #194.This PR has 2 commits (for now), the 1st mostly avoids touching
SMTPConnection
and focuses on everything around it, while the 2nd is focused on theSMTPConnection
class. I figured this split might be helpful in reviewing (plus it reflects the order of my work), but I can squash the commits if you wish.