Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump micrometer from 1.6.2 to 1.8.4 #132

Merged
merged 1 commit into from Mar 18, 2022
Merged

Bump micrometer from 1.6.2 to 1.8.4 #132

merged 1 commit into from Mar 18, 2022

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Jan 26, 2022

Motivation:

Maintenance/ Keep dependencies up to date

@yeikel yeikel changed the title Bump micrometer to 1.8.2 Bump micrometer from 1.6.2 to 1.8.2 Jan 26, 2022
@vietj vietj added this to the 4.3.0 milestone Jan 27, 2022
@tsegismont
Copy link
Contributor

tsegismont commented Jan 28, 2022 •
edited

@yeikel on the vertx user group you said you had issues with metrics when upgrading to this version but it seems our test suite does not detect any regression.

Can you elaborate on the issues?

@yeikel
Copy link
Contributor Author

yeikel commented Jan 28, 2022

@yeikel on the vertx user group you said you add issues with metrics when upgrading to this version but it seems our test suite does not detect any regression.

Can you elaborate on the issues?

@tsegismont

Are you referring to
https://groups.google.com/g/vertx/c/9mCsl4rKhhc/m/Jaeh64rPAQAJ?

I am not the one who reported problems with this version. The email you're referring to was signed by "Clive"

@tsegismont
Copy link
Contributor

@yeikel yes I was. Sorry for the confusion.

@yeikel
Copy link
Contributor Author

yeikel commented Jan 28, 2022

@yeikel yes I was. Sorry for the confusion.

No problem! Thank you for checking

Let me know if you publish any snapshot for this upgrade so I can also test it as well

@tsegismont
Copy link
Contributor

tsegismont commented Jan 28, 2022 via email

@yeikel yeikel changed the title Bump micrometer from 1.6.2 to 1.8.2 Bump micrometer from 1.6.2 to 1.8.3 Feb 22, 2022
@yeikel
Copy link
Contributor Author

yeikel commented Feb 22, 2022

Please note that 1.8.3 was just released and I just updated this PR instead

@yeikel yeikel force-pushed the patch-1 branch 2 times, most recently from 70ea9c7 to d2b7516 Compare February 26, 2022 21:46
@yeikel yeikel changed the title Bump micrometer from 1.6.2 to 1.8.3 Bump micrometer from 1.6.2 to 1.8.4 Mar 17, 2022
@yeikel
Copy link
Contributor Author

yeikel commented Mar 17, 2022

Note that 1.8.4 was just released and I updated the PR instead

tsegismont
tsegismont approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yeikel

@tsegismont tsegismont merged commit 82fa6ff into vert-x3:master Mar 18, 2022
@yeikel yeikel deleted the patch-1 branch March 18, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsegismont tsegismont tsegismont approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yeikel @tsegismont @vietj