fix(noopGauge): fix NoopGauge going to infinite #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @cristian-joseb . As explained in #169 , there is a fix already for I'm closing this PR and will apply the fix we already have instead. |
|
@tsegismont when is this planned to be applied, we want to update out code base, since we still are working on migrating to Vertx4. |
|
I saw the PR was merged, thank you @tsegismont :) |
|
You're welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
When applying a Meter filter that return MeterFilterReply.DENY, a Gauge of type NoopGauge is returned, which is making the function not being executed then gauge.value() is called. This cause the Gauges.get method going on a infinity loop because of the
if (candidateFunc.invoked)always returning false.Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines