Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in the http_server metrics documentation #180

Merged
merged 1 commit into from May 3, 2023
Merged

Fix a typo in the http_server metrics documentation #180

merged 1 commit into from May 3, 2023

Conversation

FlorentClarret
Copy link
Contributor

This metrics should be named vertx_http_server_active_ws_connections and not vertx_http_client_active_ws_connections. See https://github.com/vert-x3/vertx-micrometer-metrics/blob/master/src/main/java/io/vertx/micrometer/impl/VertxHttpServerMetrics.java#L64

tsegismont
tsegismont approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FlorentClarret !

@tsegismont tsegismont merged commit 459ef34 into vert-x3:master May 3, 2023
3 of 4 checks passed
@FlorentClarret FlorentClarret deleted the patch-1 branch May 3, 2023 13:45
tsegismont pushed a commit that referenced this pull request May 4, 2023
@FlorentClarret @tsegismont
Fix a typo in the http_server metrics documentation (#180)
6be4ae8
@tsegismont tsegismont added this to the 4.4.2 milestone May 4, 2023
@tsegismont
Copy link
Contributor

Backported to 4.x (6be4ae8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsegismont tsegismont tsegismont approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FlorentClarret @tsegismont