Distinct feature #53
Distinct feature #53
Conversation
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Objects; | ||
| import java.util.*; | ||
| import java.util.function.Function; |
There was a problem hiding this comment.
We prefer explicit imports over wildcards
|
This is looking good so far... Also will need an example added (vertx-mongo-client/src/main/java/examples/Examples.java) and the packge-info updated to show that example |
|
Corrections done. |
|
I'm happy with this @johnoliver ? |
|
And thanks for the great contribution! |
|
@etourdot Our apologies for taking so long, unfortunately mainline has moved on slightly. Are you able to merge the changes (resolve conflicts) and push again? |
|
Eurgh, SO sorry about this. Was about to merge this but then merged a different change ahead of this and its now non-mergable. If you can pull from master and push I will merge it. Be careful when merging, there is a new test |
|
No problem, i will resolve conflicts tonight |
Conflicts: vertx-mongo-client/src/main/java/io/vertx/ext/mongo/impl/MongoClientImpl.java vertx-mongo-client/src/test/java/io/vertx/ext/mongo/MongoClientTestBase.java
|
Conflicts resolved |
|
@johnoliver all yours for a final review |
|
Thank you very much for the contribution |
This a PR proposition for #50 enhancement