Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled exceptions should be reported to the context exception handler #68

Merged
merged 1 commit into from Feb 15, 2017
Merged

Unhandled exceptions should be reported to the context exception handler #68

merged 1 commit into from Feb 15, 2017

Conversation

tsegismont
Copy link
Contributor

Currently they are just logged.

@cescoffier
Copy link
Member

👍

Narigo
Narigo approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@Narigo Narigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better than before. Thanks!

@Narigo Narigo merged commit c59faa5 into vert-x3:master Feb 15, 2017
@Narigo Narigo removed the to review label Feb 15, 2017
@tsegismont tsegismont deleted the unhandled-exceptions branch February 16, 2017 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narigo Narigo Narigo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsegismont @cescoffier @Narigo