Skip to content

Commit

Permalink
Revert the api change and deprecated nullArg as it's a deviation from…
Browse files Browse the repository at this point in the history
… the official protocol

Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
  • Loading branch information
pmlopes committed May 20, 2021
1 parent 21f9eff commit 05100c0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/main/java/io/vertx/redis/client/RedisOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,9 @@ public int getPoolCleanerInterval() {
/**
* Tune how often in milliseconds should the connection pool cleaner execute.
*
* For each connection in the pool, connections marked as invalid will be forcibly closed. A connection is marked
* invalid if it enters a exception or fatal state.
*
* @param poolCleanerInterval the interval in milliseconds (-1 for never)
* @return fluent self.
*/
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/io/vertx/redis/client/Request.java
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,9 @@ default Request arg(JsonArray arg) {
}

/**
* @deprecated REDIS does not support {@code null} as a parameter, only as response. This was a deviation from the
* official protocol which should be avoided. Other clients explicitly do not allow this.
*
* Adds a {@code null} encoded string. Redis does not allow storing the {@code null} value by itself. This method
* will encode any null value as the four character long string {@code "null"}.
*
Expand All @@ -227,6 +230,7 @@ default Request arg(JsonArray arg) {
* @return self
*/
@Fluent
@Deprecated
Request nullArg();

/**
Expand Down

0 comments on commit 05100c0

Please sign in to comment.