Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Unix sockets #90

Closed
ankushs92 opened this issue Oct 12, 2017 · 3 comments
Closed

Support for Unix sockets #90

ankushs92 opened this issue Oct 12, 2017 · 3 comments
Labels
enhancement
Milestone
3.5.1

Comments

@ankushs92
Copy link

Hey guys,
We've been using vertx-redis-client for a while in production now, and so far everything is great.
We are currently exploring libraries that provide support for connecting to Redis via Unix sockets. Any plans on providing this feature in the near future?
@vietj
Copy link
Contributor

vietj commented Oct 12, 2017

@ankushs92 Vert.x 3.5 provides support for Unix domain sockets and the actual Redis client uses a NetClient, however it does not expose the domain socket setting but it should be easy to achieve, would you mind to contribute such feature ?

@BillyYccc BillyYccc mentioned this issue Oct 15, 2017
Merged
@BillyYccc
Copy link
Member

I made a PR to enable the domain socket option in Redis client.

@pmlopes pmlopes added this to the 3.5.1 milestone Dec 14, 2017
@pmlopes
Copy link
Member

pmlopes commented Dec 14, 2017

Fixed by #91

@pmlopes pmlopes closed this as completed Dec 14, 2017
@ankushs92 ankushs92 mentioned this issue Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
3.5.1
Development

No branches or pull requests
4 participants
@vietj @pmlopes @BillyYccc @ankushs92