Improve javadoc of connection pool options #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The recycle timeout was probably meant to be a timeout after which an unused connection is closed and evicted. However, the existing implementation doesn't do that -- it computes expiration time when the connection is created, and then never updates it. This PR just reflects reality. It shouldn't be hard to fix that -- whenever the connection is returned back to the connection pool, the expiration time would have to be recomputed. That would be enough. I can do that in a 2nd commit in this PR, or separately. Any thoughts? |
Ladicek
force-pushed
the
pool-options-javadoc
branch
from
c8b5182
to
84d042b
Compare
|
💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #288