Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #50 - setWithOptions does return simple String value #51

Merged
merged 1 commit into from
Mar 11, 2016

Conversation

pmlopes
Copy link
Member

@pmlopes pmlopes commented Mar 9, 2016

Fix #50

@cescoffier
Copy link
Member

Thinking about compatibility. I guess it's ok, as before the user would not have used the parameter:

    ...,
   ar -> { 
      // do nothing with ar.result()
   }

Now he can use it. The only weird case would be a check to null, but I guess this is more a bug in his application.

So 👍

pmlopes added a commit that referenced this pull request Mar 11, 2016
Fixes: #50 - setWithOptions does return simple String value
@pmlopes pmlopes merged commit 382c99b into master Mar 11, 2016
@pmlopes pmlopes removed the to review label Mar 11, 2016
@pmlopes pmlopes deleted the issues/issue-50 branch May 9, 2016 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants