Record retrieval with ConsulServiceDiscovery may be incorrect

[nedcg]

Once i retrieve a service reference trough ConsulServiceDiscovery, i'm getting:

Vertx record:

Consul Service:

i think the location.host should be the ServiceAdress and not the Consul node Address...

Im using vertx 3.3.3

[nedcg]

Now i understand the problem.

Currently vertx assume that in the service definition "Node.Address" is always pointing to the service address but this seems only correct when the service is in a container running a consul agent, if the service container does not have a consul agent, the service definition "Node.Adress" will contain the consul server address.

[faferreyra]

Found the same problem. I think it's wrong to use the Node.Address value, as it advertises the Consul agent that registered the service.

I would push a PR with my "opinionated" fix, but it's open to discussion.

[cescoffier]

Should be fixed by #62