New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc for verticle-deploy usage #30
Conversation
Sync with forked
Sync with forked
@EmadAlblueshi thanks for the PR. Vert.x docs are generated from the package file. You should update this file and then regenerate the docs by building the project (include the generated files in your commit) See the How is managed vert.x documentation wiki page for details. |
@tsegismont Got it 👍 |
@tsegismont is it ok ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the typo and squash your commits? Squashing is not a requirement but since this one is fairly simple a single commit would be better IMO
@@ -291,7 +291,7 @@ | |||
* . Verticle commands | |||
* .. verticle-ls: list all deployed verticles | |||
* .. verticle-undeploy: undeploy a verticle | |||
* .. verticle-deploy: deployes a verticle | |||
* .. verticle-deploy: deployes a verticle with deployment options as JSON string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you fix the typo ("deployes")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsegismont Done
Thank you @EmadAlblueshi |
@tsegismont You are more than welcome and I'm very glad to contribute :-) |
A tiny update for verticle-deploy usage