Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for verticle-deploy usage #30

Merged
merged 5 commits into from Sep 20, 2016
Merged

Update doc for verticle-deploy usage #30

merged 5 commits into from Sep 20, 2016

Conversation

EmadAlblueshi
Copy link
Contributor

A tiny update for verticle-deploy usage

@tsegismont
Copy link
Contributor

@EmadAlblueshi thanks for the PR. Vert.x docs are generated from the package file. You should update this file and then regenerate the docs by building the project (include the generated files in your commit)

See the How is managed vert.x documentation wiki page for details.

@EmadAlblueshi
Copy link
Contributor Author

@tsegismont Got it 👍

@EmadAlblueshi
Copy link
Contributor Author

@tsegismont is it ok ?

Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the typo and squash your commits? Squashing is not a requirement but since this one is fairly simple a single commit would be better IMO

@@ -291,7 +291,7 @@
* . Verticle commands
* .. verticle-ls: list all deployed verticles
* .. verticle-undeploy: undeploy a verticle
* .. verticle-deploy: deployes a verticle
* .. verticle-deploy: deployes a verticle with deployment options as JSON string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix the typo ("deployes")?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmadAlblueshi EmadAlblueshi changed the title Update verticle-deploy usage in all docs Update doc for verticle-deploy usage Sep 20, 2016
@tsegismont tsegismont merged commit 9ef0e4b into vert-x3:master Sep 20, 2016
@tsegismont
Copy link
Contributor

Thank you @EmadAlblueshi

@EmadAlblueshi
Copy link
Contributor Author

@tsegismont You are more than welcome and I'm very glad to contribute :-)

@EmadAlblueshi EmadAlblueshi deleted the verticle-deploy-doc branch September 20, 2016 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants