Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default error page title text is "Matron!"?? #1187

Closed
lukehutch opened this issue Mar 5, 2019 · 4 comments
Closed

Default error page title text is "Matron!"?? #1187

lukehutch opened this issue Mar 5, 2019 · 4 comments
Milestone

Comments

@lukehutch
Copy link
Contributor

Version

  • vert.x web: master

Context

The default error page says "Matron!" in large letters. Whaaat?

https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/ErrorHandlerImpl.java#L111

I think this is an effort to be cute, and that this is supposed to indicate that the hospital matron is being called, or something?

I really (really) don't think this is a good default.

@slinkydeveloper
Copy link
Member

Hi, are you willing to contribute to provide a better default error page?

@lukehutch
Copy link
Contributor Author

Sure -- there are lots of possibilities (e.g. showing a nice page with a Vert.x logo, or a bare page like the Chrome page showing a little dinosaur logo when a page cannot be reached) -- but even just changing "Matron!" to "An unexpected error occurred" would be sufficient, I think...

Also, to adhere to a "secure by default" mindset, the default error page should not show a stacktrace (although the stacktrace should be shown in the log).

lukehutch added a commit to lukehutch/vertx-web that referenced this issue Jun 11, 2019
@lukehutch
Copy link
Contributor Author

See #1299

lukehutch added a commit to lukehutch/vertx-web that referenced this issue Jun 12, 2019
@slinkydeveloper slinkydeveloper added this to the 3.8.0 milestone Jun 12, 2019
@lukehutch
Copy link
Contributor Author

Fixed in #1187.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants