Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vertx-web-api-service optional in vertx-web-openapi #1878

Closed
vietj opened this issue Feb 25, 2021 · 1 comment · Fixed by #1882
Closed

Make vertx-web-api-service optional in vertx-web-openapi #1878

vietj opened this issue Feb 25, 2021 · 1 comment · Fixed by #1882
Assignees
@slinkydeveloper
Labels
component/openapi enhancement
Milestone
4.0.3

Comments

@vietj
Copy link
Contributor

vietj commented Feb 25, 2021

When people don't use vertx-web-api-service, they should not have to have it on the class path so we should have this being an optional dependence.
@vietj vietj added this to the 4.0.3 milestone Feb 25, 2021
@vietj
Copy link
Contributor Author

vietj commented Feb 25, 2021

See vert-x3/vertx-rx#248

slinkydeveloper added a commit that referenced this issue Mar 1, 2021
@slinkydeveloper
Fix #1878
b4ba0a8 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper mentioned this issue Mar 1, 2021
Merged
slinkydeveloper added a commit that referenced this issue Mar 3, 2021
@slinkydeveloper
vertx-web-api-service now it's optional for vertx-web-openapi (#1882)
3bc3f31 
* Fix #1878

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fixed the dep hack

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slinkydeveloper slinkydeveloper

Labels
component/openapi enhancement
Milestone
4.0.3
Development

Successfully merging a pull request may close this issue.

vertx-web-api-service now it's optional for vertx-web-openapi vert-x3/vertx-web
2 participants
@vietj @slinkydeveloper