Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualHostHandler does not work with HTTP/2 #610

Closed
vietj opened this issue Apr 20, 2017 · 2 comments
Closed

VirtualHostHandler does not work with HTTP/2 #610

vietj opened this issue Apr 20, 2017 · 2 comments

Comments

@vietj
Copy link
Contributor

vietj commented Apr 20, 2017

The current VirtualHostHandler uses ctx.request().getHeader("host") to determine the host.

This does not work with HTTP/2 and instead ctx.request().host() should be used.

An HTTP/2 test for the VirtualHostHandler should be added.
@EmadAlblueshi
Copy link
Contributor

I will take care of it

@EmadAlblueshi EmadAlblueshi mentioned this issue Apr 24, 2017
Closed
@tsegismont
Copy link
Contributor

Fixed via 767f5b1

Thanks @EmadAlblueshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vietj @tsegismont @EmadAlblueshi