Reorganized Router error handling #1140 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: francesco <francescoguard@gmail.com>
|
I think it's fine for 3.6.3 |
vietj
reviewed
Jan 24, 2019
| This can then be handled by your own error handler, or perhaps the augmented error handler that we supply to use, | ||
| or if no error handler is provided Vert.x-Web will send back a basic 404 (Not Found) response. | ||
|
|
||
| A default 404 error handler is provided by Router. Anyway you can provide your own 404 error handler with |
There was a problem hiding this comment.
No need for "Anyway", simply "You can provide..."
vietj
reviewed
Jan 24, 2019
| @@ -363,10 +363,24 @@ default void accept(HttpServerRequest request) { | |||
| * | |||
| * @param exceptionHandler the exception handler | |||
| * @return a reference to this, so the API can be used fluently | |||
| * @deprecated you should use {@link Router#errorHandler(int, Handler)} with 500 status code | |||
There was a problem hiding this comment.
do we want to remove that in Vert.x 4 ?
There was a problem hiding this comment.
yes this is the idea. Maybe we can put the new method in 3.7 and remove the old one in 4
There was a problem hiding this comment.
And of course I will reflect these changes in vertx-web-api-contract too
vietj
reviewed
Jan 24, 2019
vietj
reviewed
Jan 24, 2019
| @@ -272,9 +273,19 @@ public Router mountSubRouter(String mountPoint, Router subRouter) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Deprecated | |||
There was a problem hiding this comment.
no need to deprecate the implementation when the base method is deprecated
pmlopes
approved these changes
Jan 25, 2019
pmlopes
pushed a commit
that referenced
this pull request
Jan 28, 2019
This was referenced Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: francesco francescoguard@gmail.com