Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When detecting request ended, make sure processing stops with an error #2439

Merged

Conversation

guss77
Copy link
Contributor

@guss77 guss77 commented Jun 19, 2023

A suggested fix for issue #2438 - if the BodyHandler was started too late, make sure the developer knows they made a mistake by logging the problem, making a suggestion for a fix, and failing the request.

… log message and a failure the developer can analyze
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @guss77

@tsegismont tsegismont merged commit 80a2a67 into vert-x3:master Jun 20, 2023
7 checks passed
@guss77
Copy link
Contributor Author

guss77 commented Jun 20, 2023

Thank you! 😃

@guss77 guss77 deleted the feature/error-on-unattached-bodyhandler branch June 20, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants