Sync protocol with latest TCK and ensure implementation is correct #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR now runs both the protocol tests and the quirk tests. |
vietj
force-pushed
the
issues/sockjs-protocol-tests
branch
from
972ba34
to
363982e
Compare
|
rebased on master |
|
thansk for the contrib! |
This was referenced Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings sockjs protocol tests back to parity with the official script. All tests pass with the exception of the
HA Proxytest (which is not supported).We went from 67 to 77 tests, and many hacks on the previous test assertions have been removed and assertions comply to the official protocol tests.