-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added validation for source and target #85
Conversation
- Fixed a bug where user can create a reverseproxy even if host or target is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Here are some request changes that need to be addressed before merging:
10e10fd
to
dac38a4
Compare
Sorry for the confusion; I think the documentation should be more explicit about this. In fact, both versions were half-right. This new version check the errors at the correct place, but doesn't returns to the client why the request has failed.
Take for example the feature to delete a container: https://github.com/vertex-center/vertex/blob/dev/apps/containers/handler/container.go#L120:L135. If the service says that the service is still running, the handler returns a response that is adapted to that. So: the service makes the verification and returns why it fails, and the http handler generates an HTTP response for this error. But appart from this I think you got it! For the empty string, this is optional for this PR but you can also use |
(Also don't hesitate to say what should be improved in the documentation about the architecture, the doc is pretty new!) |
Thanks @quentinguidee for the explanation. Actually, my both solutions were half-baked at their own places based on what actually this repo expects. |
fixing the lint errors. |
Looks good to me! Thank you for your contribution 🚀 |
Related issue: #54