New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow map_async option for faster write performance #1338
Conversation
self.onfini(self.layrslab.fini) | ||
|
||
self.spliceslab = await s_lmdbslab.Slab.anit(splicepath, max_dbs=128, map_size=mapsize, maxsize=maxsize, | ||
growsize=growsize, writemap=True, readahead=readahead) | ||
growsize=growsize, writemap=True, readahead=readahead, map_async=map_async) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in _onCoFini do we need to call self.lenv.sync(force=True)
during teardown if this option is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, he def does the sync for us :)
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 94.96% 94.96% +<.01%
==========================================
Files 122 122
Lines 15434 15437 +3
==========================================
+ Hits 14657 14660 +3
Misses 777 777
Continue to review full report at Codecov.
|
No description provided.