Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature link coverage #1365

Merged
merged 5 commits into from Sep 10, 2019
Merged

Feature link coverage #1365

merged 5 commits into from Sep 10, 2019

Conversation

vEpiphyte
Copy link
Contributor

Begging for (link.py) coverage makes me angry.

@vEpiphyte vEpiphyte added this to the v0.1.26 milestone Sep 7, 2019
@vEpiphyte vEpiphyte self-assigned this Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #1365 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
+ Coverage   94.88%   94.98%   +0.09%     
==========================================
  Files         131      131              
  Lines       18078    18078              
==========================================
+ Hits        17154    17171      +17     
+ Misses        924      907      -17
Flag Coverage Δ
#linux 94.94% <ø> (+4.94%) ⬆️
#osx 93.27% <ø> (+0.04%) ⬆️
Impacted Files Coverage Δ
synapse/lib/link.py 100% <0%> (+7.56%) ⬆️
synapse/lib/platforms/linux.py 94.04% <0%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f2202...f49f0e0. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #1365 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
+ Coverage   94.96%   94.98%   +0.02%     
==========================================
  Files         131      131              
  Lines       18083    18083              
==========================================
+ Hits        17172    17176       +4     
+ Misses        911      907       -4
Flag Coverage Δ
#linux 94.95% <ø> (+0.04%) ⬆️
#osx 93.27% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
synapse/lib/link.py 100% <0%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6750749...027ec61. Read the comment docs.

@invisig0th invisig0th merged commit 59334a6 into master Sep 10, 2019
@invisig0th invisig0th deleted the feature_link_coverage branch September 10, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants