Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where removal of tag prop wouldn't update Node #1454

Merged
merged 1 commit into from Dec 10, 2019

Conversation

jnwatson
Copy link
Contributor

Fix issue where removing a tag prop e.g. [ -#foo:score ] would still have the tagprop returned in the Node.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #1454 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   95.39%   95.37%   -0.02%     
==========================================
  Files         133      133              
  Lines       20469    20468       -1     
==========================================
- Hits        19526    19521       -5     
- Misses        943      947       +4
Flag Coverage Δ
#linux 95.37% <100%> (+0.01%) ⬆️
#osx ?
Impacted Files Coverage Δ
synapse/lib/node.py 98.68% <100%> (-0.01%) ⬇️
synapse/lib/platforms/darwin.py 0% <0%> (-100%) ⬇️
synapse/lib/thisplat.py 58.33% <0%> (-8.34%) ⬇️
synapse/lib/link.py 98.54% <0%> (-0.73%) ⬇️
synapse/lib/lmdbslab.py 98.91% <0%> (-0.16%) ⬇️
synapse/lib/base.py 92.05% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1170a54...2802e61. Read the comment docs.

@vEpiphyte vEpiphyte added this to the v0.1.41 milestone Dec 10, 2019
@vEpiphyte vEpiphyte added the bug label Dec 10, 2019
@jnwatson jnwatson merged commit 7d4e3be into master Dec 10, 2019
@vEpiphyte vEpiphyte deleted the tagprop-del-bug branch January 1, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants