Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial display hinting for props #1892

Merged
merged 12 commits into from Oct 6, 2020
Merged

Conversation

whippit
Copy link
Contributor

@whippit whippit commented Sep 29, 2020

First pass to provide display hinting for properties that may benefit from multi line display.

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #1892 into master will increase coverage by 3.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1892      +/-   ##
==========================================
+ Coverage   90.19%   93.31%   +3.12%     
==========================================
  Files         139      139              
  Lines       26208    26208              
==========================================
+ Hits        23637    24456     +819     
+ Misses       2571     1752     -819     
Flag Coverage Δ
#linux 93.31% <ø> (+3.12%) ⬆️
#linux_replay 69.57% <ø> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/inet.py 99.28% <ø> (ø)
synapse/models/infotech.py 100.00% <ø> (ø)
synapse/models/language.py 100.00% <ø> (ø)
synapse/models/media.py 100.00% <ø> (ø)
synapse/models/orgs.py 100.00% <ø> (ø)
synapse/models/risk.py 100.00% <ø> (ø)
synapse/models/syn.py 98.38% <ø> (ø)
synapse/models/telco.py 100.00% <ø> (ø)
synapse/tools/feed.py 0.00% <0.00%> (-82.80%) ⬇️
synapse/cmds/hive.py 18.84% <0.00%> (-81.16%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5302c00...d322a0f. Read the comment docs.

synapse/models/inet.py Outdated Show resolved Hide resolved
@whippit whippit marked this pull request as ready for review October 1, 2020 15:02
@whippit whippit changed the title WIP: initial display hinting for props initial display hinting for props Oct 2, 2020
vEpiphyte
vEpiphyte previously approved these changes Oct 6, 2020
@vEpiphyte vEpiphyte added this to the 2.9.0 milestone Oct 6, 2020
synapse/models/inet.py Outdated Show resolved Hide resolved
@invisig0th invisig0th merged commit 5d54696 into master Oct 6, 2020
@invisig0th invisig0th deleted the multiline-display-hints branch October 6, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants