Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Axon wget use iter_chunked to work with vcrpy #2030

Merged
merged 1 commit into from Dec 28, 2020

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Dec 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #2030 (a678c9c) into master (0325f20) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
- Coverage   96.77%   96.62%   -0.15%     
==========================================
  Files         148      148              
  Lines       29126    29124       -2     
==========================================
- Hits        28186    28142      -44     
- Misses        940      982      +42     
Flag Coverage Δ
linux 96.62% <100.00%> (-0.15%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/axon.py 98.90% <100.00%> (-0.01%) ⬇️
synapse/tests/utils.py 93.66% <0.00%> (-2.16%) ⬇️
synapse/cortex.py 95.75% <0.00%> (-0.76%) ⬇️
synapse/lib/hiveauth.py 96.05% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 94.19% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/layer.py 98.24% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0325f20...a678c9c. Read the comment docs.

@invisig0th invisig0th merged commit 5ca0611 into master Dec 28, 2020
@invisig0th invisig0th deleted the wget-workaround branch December 28, 2020 15:39
@vEpiphyte vEpiphyte added the bug label Dec 29, 2020
@vEpiphyte vEpiphyte added this to the v2.20.0 milestone Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants