Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix idempotency issues with deleting a form #2112

Merged
merged 2 commits into from Mar 17, 2021
Merged

Fix idempotency issues with deleting a form #2112

merged 2 commits into from Mar 17, 2021

Conversation

jnwatson
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2112 (9c8fc1f) into master (776bfd0) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   96.95%   96.82%   -0.14%     
==========================================
  Files         151      151              
  Lines       30222    30226       +4     
==========================================
- Hits        29303    29266      -37     
- Misses        919      960      +41     
Flag Coverage Δ
linux 96.82% <100.00%> (-0.14%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 95.92% <100.00%> (-0.67%) ⬇️
synapse/datamodel.py 94.78% <100.00%> (ø)
synapse/tests/utils.py 93.77% <0.00%> (-2.12%) ⬇️
synapse/lib/hiveauth.py 96.10% <0.00%> (-0.75%) ⬇️
synapse/lib/view.py 94.18% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/layer.py 98.28% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 776bfd0...9c8fc1f. Read the comment docs.

synapse/datamodel.py Show resolved Hide resolved
synapse/tests/test_datamodel.py Show resolved Hide resolved
@vEpiphyte vEpiphyte added the bug label Mar 17, 2021
@vEpiphyte vEpiphyte added this to the v2.30.0 milestone Mar 17, 2021
@vEpiphyte vEpiphyte merged commit 8d35114 into master Mar 17, 2021
@vEpiphyte vEpiphyte deleted the replay-fix branch March 17, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants