New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat struct log #2179
Merged
Merged
Feat struct log #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vEpiphyte
commented
May 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #2179 +/- ##
==========================================
- Coverage 97.16% 97.03% -0.14%
==========================================
Files 158 159 +1
Lines 31791 31819 +28
==========================================
- Hits 30889 30874 -15
- Misses 902 945 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vEpiphyte
commented
May 6, 2021
invisig0th
reviewed
May 7, 2021
…up logging. Push this into the cell config as a opaque configuration blob for spawnprocs; use that for spawn procs.
jnwatson
previously requested changes
May 13, 2021
invisig0th
reviewed
May 13, 2021
invisig0th
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add structured logging option