wget UA #2208
Merged
wget UA #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2208 +/- ##
==========================================
- Coverage 97.25% 97.06% -0.20%
==========================================
Files 159 159
Lines 32089 32089
==========================================
- Hits 31209 31146 -63
- Misses 880 943 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
invisig0th
requested changes
May 24, 2021
synapse/axon.py
Outdated
| # lower the keys | ||
| lheaders = dict((h.lower(), v) for h, v in headers.items()) | ||
|
|
||
| defheaders = { |
There was a problem hiding this comment.
how would we exclude one of these defaults ( to make it not present rather than have a new value? )
There was a problem hiding this comment.
I think this kind of logic probably belongs in the command implementation not the library
invisig0th
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--headersand--paramsswitches for storm wget command