WIP Add checkhost() to allow warn on sub-optimal configs #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisig0th
commented
Aug 30, 2021
synapse/lib/cell.py
Outdated
| @@ -2168,6 +2168,9 @@ async def execmain(cls, argv, outp=None): | |||
| if outp is None: | |||
| outp = s_output.stdout | |||
|
|
|||
| if not int(os.getenv('CELL_CHECKHOST', '1')): | |||
There was a problem hiding this comment.
What should this env var really be named?
There was a problem hiding this comment.
- we have a envbool helper in synapse.common
- SYN_CHECKHOST ?
There was a problem hiding this comment.
This is better done inside of initFromArgv to allow for picking up on structured logging
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
- Coverage 97.17% 97.01% -0.17%
==========================================
Files 194 194
Lines 36268 36293 +25
==========================================
- Hits 35243 35209 -34
- Misses 1025 1084 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.