Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for async triggers #2464

Merged
merged 18 commits into from Nov 16, 2021
Merged

Adds support for async triggers #2464

merged 18 commits into from Nov 16, 2021

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2464 (0868f1e) into master (f1292d7) will decrease coverage by 0.11%.
The diff coverage is 98.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2464      +/-   ##
==========================================
- Coverage   97.17%   97.05%   -0.12%     
==========================================
  Files         194      194              
  Lines       35990    36054      +64     
==========================================
+ Hits        34972    34991      +19     
- Misses       1018     1063      +45     
Flag Coverage Δ
linux 97.05% <98.96%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/view.py 94.27% <97.91%> (-0.34%) ⬇️
synapse/cortex.py 96.37% <100.00%> (-0.66%) ⬇️
synapse/lib/cell.py 97.82% <100.00%> (+<0.01%) ⬆️
synapse/lib/lmdbslab.py 99.71% <100.00%> (+<0.01%) ⬆️
synapse/lib/storm.py 98.41% <100.00%> (-0.06%) ⬇️
synapse/lib/stormtypes.py 98.65% <100.00%> (+<0.01%) ⬆️
synapse/lib/trigger.py 94.88% <100.00%> (+0.12%) ⬆️
synapse/tests/utils.py 94.00% <0.00%> (-2.05%) ⬇️
synapse/lib/hiveauth.py 96.22% <0.00%> (-0.72%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1292d7...0868f1e. Read the comment docs.

@invisig0th invisig0th changed the title WIP: Adds support for async triggers Adds support for async triggers Nov 11, 2021
synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/lib/trigger.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Cisphyx Cisphyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add an async column to the trigger.list command output

synapse/lib/view.py Outdated Show resolved Hide resolved
Cisphyx
Cisphyx previously approved these changes Nov 12, 2021
synapse/lib/view.py Outdated Show resolved Hide resolved
@invisig0th invisig0th merged commit fd029e8 into master Nov 16, 2021
@invisig0th invisig0th deleted the visi-trig-async branch November 16, 2021 19:41
@vEpiphyte vEpiphyte added this to the v2.7x.x milestone Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants