Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus - Only set ahaready when ahasvcname is set. (SYN-3743) #2723

Merged
merged 4 commits into from Jun 17, 2022

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label Jun 17, 2022
@vEpiphyte vEpiphyte added this to the v2.9x.x milestone Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #2723 (314a283) into master (f90c645) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2723      +/-   ##
==========================================
- Coverage   96.94%   96.83%   -0.11%     
==========================================
  Files         206      206              
  Lines       39973    39973              
==========================================
- Hits        38750    38708      -42     
- Misses       1223     1265      +42     
Flag Coverage Δ
linux 96.83% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/nexus.py 95.37% <100.00%> (ø)
synapse/tests/utils.py 93.69% <0.00%> (-1.98%) ⬇️
synapse/cortex.py 96.61% <0.00%> (-0.59%) ⬇️
synapse/lib/hiveauth.py 95.71% <0.00%> (-0.52%) ⬇️
synapse/lib/trigger.py 94.98% <0.00%> (-0.39%) ⬇️
synapse/lib/view.py 96.96% <0.00%> (-0.34%) ⬇️
synapse/lib/jsonstor.py 98.30% <0.00%> (-0.25%) ⬇️
synapse/lib/layer.py 96.72% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f90c645...314a283. Read the comment docs.

@vEpiphyte vEpiphyte merged commit 39938c0 into master Jun 17, 2022
@vEpiphyte vEpiphyte deleted the bug_nexus_tellready branch June 17, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants