Create general use proc pool (SYN-4901)

[mikemoritz]

No description provided.

[codecov]

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.13 ⚠️

Comparison is base (a8c4f2c) 97.31% compared to head (75503c4) 97.18%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
- Coverage   97.31%   97.18%   -0.13%     
==========================================
  Files         225      225              
  Lines       45009    45014       +5     
==========================================
- Hits        43799    43748      -51     
- Misses       1210     1266      +56     

Flag	Coverage Δ
linux	97.18% <83.33%> (-0.03%)	⬇️
linux_replay	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
synapse/tests/utils.py	94.49% <66.66%> (-1.94%)	⬇️
synapse/lib/coro.py	97.50% <77.77%> (-0.49%)	⬇️
synapse/lib/parser.py	98.51% <100.00%> (ø)
synapse/lib/stormlib/json.py	100.00% <100.00%> (ø)
synapse/lib/stormlib/mime.py	86.66% <100.00%> (-13.34%)	⬇️
synapse/lib/stormlib/stix.py	98.27% <100.00%> (-0.87%)	⬇️
synapse/lib/stormlib/xml.py	97.61% <100.00%> (-0.16%)	⬇️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[vEpiphyte]

Is the intent that we log the # of workers upon service startup?

This will be logged during import time; which is prior to any logger configuration occurring.
If we set a default max_workers = None value than the workers is safe to refer to from other modules and log the # of as needed.

[mikemoritz]

We already had the logger.warning there, but yeah, it hasn't been configured yet. I removed this debug logging, and maybe we should consider making the warning a python warning.