Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load files in getSslCtx (SYN-5582) #3179

Merged
merged 2 commits into from Jun 12, 2023
Merged

Conversation

vEpiphyte
Copy link
Contributor

since we load with cafile argument we should skip directory loading

@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jun 11, 2023
@vEpiphyte vEpiphyte added this to the v2.13x.x milestone Jun 11, 2023
@codecov
Copy link

codecov bot commented Jun 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (7cae88e) 97.33% compared to head (973d429) 97.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
- Coverage   97.33%   97.24%   -0.10%     
==========================================
  Files         224      224              
  Lines       44798    44800       +2     
==========================================
- Hits        43606    43564      -42     
- Misses       1192     1236      +44     
Flag Coverage Δ
linux 97.24% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/tests/utils.py 94.58% <ø> (-1.84%) ⬇️
synapse/common.py 98.12% <100.00%> (+<0.01%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

invisig0th
invisig0th previously approved these changes Jun 11, 2023
@vEpiphyte vEpiphyte changed the title Only load files in getSlCtx (SYN-5582) Only load files in getSslCtx (SYN-5582) Jun 12, 2023
@vEpiphyte vEpiphyte merged commit b09c90a into master Jun 12, 2023
8 checks passed
@vEpiphyte vEpiphyte deleted the feat_sslctx_fileonly branch June 12, 2023 12:58
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants