Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize graph mode output, use proper scope for lib.pipe, fix cpe auto-extension normalization #3186

Merged
merged 14 commits into from Jun 16, 2023

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (44ccf2b) 97.34% compared to head (dfc9a81) 97.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
- Coverage   97.34%   97.25%   -0.09%     
==========================================
  Files         224      224              
  Lines       44841    44833       -8     
==========================================
- Hits        43649    43601      -48     
- Misses       1192     1232      +40     
Flag Coverage Δ
linux 97.25% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.91% <100.00%> (-0.01%) ⬇️
synapse/lib/snap.py 95.44% <100.00%> (+0.41%) ⬆️
synapse/lib/stormtypes.py 98.77% <100.00%> (-0.01%) ⬇️
synapse/models/infotech.py 98.68% <100.00%> (+0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte added this to the v2.13x.x milestone Jun 14, 2023
@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Jun 14, 2023
@invisig0th invisig0th changed the title Add more aggressive async yields during graph generation optimize graph mode output, use proper scope for lib.pipe, fix cpe auto-extension normalization Jun 15, 2023
mikemoritz
mikemoritz previously approved these changes Jun 16, 2023
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't allow invalid cpe 2.3 strings through norm

@invisig0th invisig0th merged commit eaf4352 into master Jun 16, 2023
8 checks passed
@invisig0th invisig0th deleted the visi-graph-sleeps branch June 16, 2023 20:56
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants