Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate cron query on add (SYN-5364) #3201

Merged
merged 2 commits into from Jun 29, 2023
Merged

Validate cron query on add (SYN-5364) #3201

merged 2 commits into from Jun 29, 2023

Conversation

mikemoritz
Copy link
Contributor

Also checked that trigger and dmon queries were validated.

@vEpiphyte vEpiphyte added the bug label Jun 27, 2023
@vEpiphyte vEpiphyte added this to the v2.140.0 milestone Jun 27, 2023
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (d95c222) 97.30% compared to head (3bd28a2) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3201      +/-   ##
==========================================
- Coverage   97.30%   97.19%   -0.11%     
==========================================
  Files         224      224              
  Lines       44823    44824       +1     
==========================================
- Hits        43616    43568      -48     
- Misses       1207     1256      +49     
Flag Coverage Δ
linux 97.19% <100.00%> (-0.02%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/agenda.py 97.01% <100.00%> (-0.60%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vEpiphyte vEpiphyte merged commit 2c30dbf into master Jun 29, 2023
5 checks passed
@vEpiphyte vEpiphyte deleted the autom-queryvalid branch June 29, 2023 13:32
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants