Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust names for storm types (SYN-5439) #3229

Merged
merged 6 commits into from Jul 12, 2023
Merged

Adjust names for storm types (SYN-5439) #3229

merged 6 commits into from Jul 12, 2023

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Jul 10, 2023

  • Remove storm: prefix from everything except storm:query
  • storm:proxy and related types are now telepath:proxy
  • Adjust project types to match the names in the data model.

Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to update older references to the heavy object names in the changelog?

@Cisphyx
Copy link
Contributor Author

Cisphyx commented Jul 11, 2023

Do we also want to update older references to the heavy object names in the changelog?

I considered it but wasn't sure if it would be more or less confusing. I suppose if they're looking at previous version docs it would still have the previous names so it probably makes sense to update it.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (60fe120) 97.29% compared to head (918cb3c) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3229      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.11%     
==========================================
  Files         225      225              
  Lines       45054    45054              
==========================================
- Hits        43837    43791      -46     
- Misses       1217     1263      +46     
Flag Coverage Δ
linux 97.19% <100.00%> (ø)
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormlib/gen.py 100.00% <ø> (ø)
synapse/lib/stormlib/infosec.py 99.43% <ø> (ø)
synapse/lib/stormhttp.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/imap.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/json.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/model.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/oauth.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/project.py 99.32% <100.00%> (ø)
synapse/lib/stormlib/smtp.py 100.00% <100.00%> (ø)
synapse/lib/stormlib/stix.py 98.27% <100.00%> (ø)
... and 1 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

vEpiphyte
vEpiphyte previously approved these changes Jul 12, 2023
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Jul 12, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 12, 2023
@Cisphyx Cisphyx merged commit ab07d7c into master Jul 12, 2023
5 checks passed
@Cisphyx Cisphyx deleted the stormtype-naming branch July 12, 2023 15:30
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants