Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds closure capture to dmon.add from Query and adds query closure from runt vars #3230

Merged
merged 4 commits into from Jul 12, 2023

Conversation

invisig0th
Copy link
Contributor

… for runt vars

synapse/lib/stormtypes.py Outdated Show resolved Hide resolved
Cisphyx
Cisphyx previously approved these changes Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (e7bb9f4) 97.29% compared to head (f2b2359) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   97.29%   97.19%   -0.10%     
==========================================
  Files         225      225              
  Lines       45038    45049      +11     
==========================================
- Hits        43820    43786      -34     
- Misses       1218     1263      +45     
Flag Coverage Δ
linux 97.19% <100.00%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.93% <100.00%> (+<0.01%) ⬆️
synapse/lib/msgpack.py 98.71% <100.00%> (+0.12%) ⬆️
synapse/lib/stormtypes.py 98.72% <100.00%> (+<0.01%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@invisig0th invisig0th merged commit 45a025b into master Jul 12, 2023
5 checks passed
@invisig0th invisig0th deleted the dmon-embed-closure branch July 12, 2023 14:07
@vEpiphyte vEpiphyte added this to the v2.142.0 milestone Jul 14, 2023
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog and removed reqChangelog requires changelog labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants