Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-5827: inet:dns:answer:time #3276

Merged
merged 4 commits into from Jul 30, 2023

Conversation

MichaelSquires
Copy link
Contributor

  • Added time prop to `inet:dns:answer' form
  • Update test to check new time prop

Resolves SYN-5827

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (ff58380) 97.32% compared to head (5b2c1f0) 97.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3276      +/-   ##
==========================================
- Coverage   97.32%   97.22%   -0.11%     
==========================================
  Files         227      227              
  Lines       45429    45429              
==========================================
- Hits        44213    44167      -46     
- Misses       1216     1262      +46     
Flag Coverage Δ
linux 97.22% <ø> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/models/dns.py 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jul 28, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Jul 28, 2023
@vEpiphyte vEpiphyte requested a review from mbvertex July 28, 2023 20:22
@invisig0th invisig0th merged commit d90a3f7 into master Jul 30, 2023
5 checks passed
@invisig0th invisig0th deleted the blackout/SYN-5827/inet-dns-answer-time branch July 30, 2023 18:39
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants