Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell reload / SIGHUP handler (SYN-5886) #3293

Merged
merged 18 commits into from Aug 18, 2023
Merged

Cell reload / SIGHUP handler (SYN-5886) #3293

merged 18 commits into from Aug 18, 2023

Conversation

vEpiphyte
Copy link
Contributor

  • Add Cell + CellAPI apis for listing and running reload functions
  • Cell.addHttpsPort now adds a reload function to reload the SSL certificates when the SSL context is not provided
  • Cell.addSignalHandlers now adds a SIGHUP handler to call all registered reload functions
  • Add synapse.tools.reload to interact with a services reload functions

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 98.30% and project coverage change: -0.10% ⚠️

Comparison is base (c31fa82) 97.32% compared to head (da6b442) 97.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3293      +/-   ##
==========================================
- Coverage   97.32%   97.22%   -0.10%     
==========================================
  Files         227      228       +1     
  Lines       45496    45613     +117     
==========================================
+ Hits        44277    44346      +69     
- Misses       1219     1267      +48     
Flag Coverage Δ
linux 97.22% <98.30%> (+<0.01%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/cell.py 98.05% <97.95%> (-0.01%) ⬇️
synapse/tools/reload.py 97.95% <97.95%> (ø)
synapse/tests/utils.py 94.64% <100.00%> (-1.71%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

synapse/lib/cell.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two minor comments 😄

synapse/tests/test_lib_cell.py Show resolved Hide resolved
synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/lib/cell.py Show resolved Hide resolved
synapse/tools/reload.py Outdated Show resolved Hide resolved
synapse/lib/cell.py Show resolved Hide resolved
MichaelSquires
MichaelSquires previously approved these changes Aug 16, 2023
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions but they're pedantic. Feel free to accept or not :)

synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/lib/cell.py Outdated Show resolved Hide resolved
synapse/tools/reload.py Outdated Show resolved Hide resolved
vEpiphyte and others added 2 commits August 16, 2023 18:05
Co-authored-by: blackout <blackout@vertex.link>
synapse/lib/cell.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Aug 18, 2023
@vEpiphyte vEpiphyte added the reqChangelog requires changelog label Aug 18, 2023
@vEpiphyte vEpiphyte merged commit da041b8 into master Aug 18, 2023
5 checks passed
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Aug 24, 2023
@vEpiphyte vEpiphyte deleted the feat_cell_reload branch September 19, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants