-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cell reload / SIGHUP handler (SYN-5886) #3293
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3293 +/- ##
==========================================
- Coverage 97.32% 97.22% -0.10%
==========================================
Files 227 228 +1
Lines 45496 45613 +117
==========================================
+ Hits 44277 44346 +69
- Misses 1219 1267 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Two minor comments 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions but they're pedantic. Feel free to accept or not :)
Co-authored-by: blackout <blackout@vertex.link>
Cell.addHttpsPort
now adds a reload function to reload the SSL certificates when the SSL context is not providedCell.addSignalHandlers
now adds a SIGHUP handler to call all registered reload functionssynapse.tools.reload
to interact with a services reload functions