Add synapse_requirement to storm package schema (SYN-5993) #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3304 +/- ##
==========================================
- Coverage 97.26% 97.16% -0.11%
==========================================
Files 228 228
Lines 45675 45679 +4
==========================================
- Hits 44426 44384 -42
- Misses 1249 1295 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
invisig0th
requested changes
Aug 22, 2023
invisig0th
requested changes
Aug 23, 2023
synapse/tests/test_lib_ast.py
Outdated
| @@ -20,7 +20,8 @@ | |||
| 'name': 'foo', | |||
| 'desc': 'The Foo Module', | |||
| 'version': (0, 0, 1), | |||
| 'synapse_minversion': (2, 8, 0), | |||
| 'synapse_minversion': [2, 144, 0], | |||
| 'synapse_version': '>=2.8.0', | |||
There was a problem hiding this comment.
Should these be ">=2.8.0,<3.0.0" since people are likely to copy them? Should we also remove the synapse_minversion keys from any tests which are potential examples?
There was a problem hiding this comment.
Yeah I'll add <3.0.0 to these, keeping a synapse_minversion in there makes sure that the cortex is updated enough to actually check the synapse_version requirement.
invisig0th
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.