Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node.py helper functions (SYN-5998) #3315

Merged
merged 4 commits into from Aug 29, 2023
Merged

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Aug 28, 2023

functions now work with podes from https apis.

@vEpiphyte vEpiphyte added bug reqChangelog requires changelog labels Aug 28, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (63782e8) 97.29% compared to head (30af9b1) 97.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3315      +/-   ##
==========================================
- Coverage   97.29%   97.18%   -0.11%     
==========================================
  Files         228      228              
  Lines       45878    45880       +2     
==========================================
- Hits        44635    44589      -46     
- Misses       1243     1291      +48     
Flag Coverage Δ
linux 97.18% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/node.py 98.10% <100.00%> (+<0.01%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

synapse/lib/node.py Show resolved Hide resolved
@invisig0th invisig0th merged commit af57762 into master Aug 29, 2023
5 checks passed
@invisig0th invisig0th deleted the feat_nodepy_helpers branch August 29, 2023 13:44
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants