Mark macro functions readonly safe, mark str type functions as readonly safe (SYN-6063) #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly safe (SYN-6063)
invisig0th
requested changes
Aug 29, 2023
| @@ -294,3 +294,29 @@ async def test_stormlib_macro_globalperms(self): | |||
| await visi.addRule((True, ('storm', 'macro', 'admin'))) | |||
| msgs = await core.stormlist('macro.del asdf', opts={'user': visi.iden}) | |||
| self.stormHasNoWarnErr(msgs) | |||
|
|
|||
| async def test_stormlib_macro_readonly(self): | |||
There was a problem hiding this comment.
Could we just add readonly options to some existing tests for macros / string methods?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3316 +/- ##
==========================================
- Coverage 97.29% 97.19% -0.10%
==========================================
Files 228 228
Lines 45880 45902 +22
==========================================
- Hits 44637 44613 -24
- Misses 1243 1289 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
invisig0th
approved these changes
Aug 29, 2023
vEpiphyte
added
reqChangelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.