Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fini cell.ahaclient if the Cell creates it (SYN-6101) #3324

Merged
merged 4 commits into from Aug 31, 2023

Conversation

vEpiphyte
Copy link
Contributor

No description provided.

@vEpiphyte vEpiphyte added the bug label Aug 31, 2023
@vEpiphyte vEpiphyte added this to the v2.14x.x milestone Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (69a28b0) 97.30% compared to head (a1e92e5) 97.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3324      +/-   ##
==========================================
- Coverage   97.30%   97.19%   -0.11%     
==========================================
  Files         228      228              
  Lines       46000    46001       +1     
==========================================
- Hits        44758    44709      -49     
- Misses       1242     1292      +50     
Flag Coverage Δ
linux 97.19% <100.00%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
synapse/lib/cell.py 97.81% <100.00%> (+<0.01%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's some value in the code from your first commit (where you added a postAnit and some other tracking code. Recommend adding that back as a test for making sure we're fini'ing everything correctly in the future.

@vEpiphyte
Copy link
Contributor Author

I wanted to leave it in the branch as a "show your work" moment; but it is a pretty easy item to recreate in the future for any other objects we may find ourselves wanting to track.

@vEpiphyte vEpiphyte merged commit 1808dff into master Aug 31, 2023
5 checks passed
@vEpiphyte vEpiphyte deleted the bug_dangling_client branch August 31, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants